You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
probeinterface renamed read_openephys to read_openephys_neuropixels (SpikeInterface/probeinterface#427) and read_spikegadgets to read_spikegadgets_neuropixels (SpikeInterface/probeinterface#440) to make the Neuropixels-only scope of those readers explicit; the old names remain as deprecation aliases. The same two PRs add detectors has_neuropixels_probes(settings_file, stream_name=...) and has_spikegadgets_neuropixels_probes(file) that parse the settings XML / .rec header and return whether the recording carries any Neuropixels probe geometry.
This PR switches the OpenEphys and SpikeGadgets extractors to call the new names and gates probe attachment on the detectors. Previously both readers were called unconditionally with raise_error=False, so a recording that legitimately had no Neuropixels probe (Intan / Rhythm FPGA / NI-DAQmx for Open Ephys, tetrodes / ECU for SpikeGadgets) silently returned None and the extractor finished probe-less. With the detector check up front the no-probe path is a normal control-flow branch, and any real parsing error from the reader now surfaces instead of being swallowed.
I
I am also removing the version guard and the packaging import, since pyproject.toml already pins probeinterface>=0.3.2.
Hello, this PR demonstrates an awkward difference between uv and traditional python venvs.
uv checks all dependency groups and prioritizes git repos over pypi releases. E.g. if you run uv run ...uv will create a venv with probeinterface from source, since this is in common-tests
If you make a venv and pip install spikeinterface from source from this PR, the resolver completely ignore common-tests and installs probeinterface v0.3.2.
The new functions are only in probeinterface main. So if you try to load a openephys neuropixel recording with a uv generated venv, it's fine. If you do it with a pip installed venv, it errors.
Hello, this PR demonstrates an awkward difference between uv and traditional python venvs.
...
Just wanted to point it out!
Maybe we should pin to github on probeinterface and python-neo on main. Probably worth its own issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
probeinterface renamed
read_openephystoread_openephys_neuropixels(SpikeInterface/probeinterface#427) andread_spikegadgetstoread_spikegadgets_neuropixels(SpikeInterface/probeinterface#440) to make the Neuropixels-only scope of those readers explicit; the old names remain as deprecation aliases. The same two PRs add detectorshas_neuropixels_probes(settings_file, stream_name=...)andhas_spikegadgets_neuropixels_probes(file)that parse the settings XML /.recheader and return whether the recording carries any Neuropixels probe geometry.This PR switches the OpenEphys and SpikeGadgets extractors to call the new names and gates probe attachment on the detectors. Previously both readers were called unconditionally with
raise_error=False, so a recording that legitimately had no Neuropixels probe (Intan / Rhythm FPGA / NI-DAQmx for Open Ephys, tetrodes / ECU for SpikeGadgets) silently returnedNoneand the extractor finished probe-less. With the detector check up front the no-probe path is a normal control-flow branch, and any real parsing error from the reader now surfaces instead of being swallowed.I
I am also removing the version guard and the
packagingimport, sincepyproject.tomlalready pinsprobeinterface>=0.3.2.